[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

John Paul Adrian Glaubitz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 9 03:41:39 PDT 2021


glaubitz accepted this revision.
glaubitz added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Driver/sanitizer-ld.c:309
 // CHECK-UBSAN-LINUX: "-lpthread"
 
 // RUN: %clang -fsanitize=undefined -fno-sanitize-link-runtime %s -### -o %t.o 2>&1 \
----------------
glaubitz wrote:
> hvdijk wrote:
> > glaubitz wrote:
> > > Do we need want to run the test for i386 anymore?
> > This test just somewhat arbitrarily distributes the different sanitizer modules over i386 and x86_64 for testing rather than testing each module for each arch, so I figured there was no harm in changing one of them to x86_64-linux-gnux32. i386 is still getting tested elsewhere.
> Do we _not_, not _need_. Sorry.
OK, thanks. Then I will mark this as approved from my side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100148/new/

https://reviews.llvm.org/D100148



More information about the cfe-commits mailing list