[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 8 13:11:39 PDT 2021


aaron.ballman added a comment.

In D75844#2677457 <https://reviews.llvm.org/D75844#2677457>, @brooksmoses wrote:

> FWIW, this now causes Clang to produce an error on this code, when it didn't before:
>
>   using namespace::foo __attribute__((deprecated("message")));
>
> I discussed this with Richard Smith, who points out that GCC does not accept this and it's not permitted according to the C++ standard, so this should probably be considered an accidental fix of a longstanding bug.   With that said, would it be useful to add this as a tested case?

I think that would be a useful test case if only to document that we explicitly expect the situation to be a parsing error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75844/new/

https://reviews.llvm.org/D75844



More information about the cfe-commits mailing list