[PATCH] D99291: [AIX] Support init priority attribute

Xiangling Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 8 07:03:59 PDT 2021


Xiangling_L marked an inline comment as done.
Xiangling_L added inline comments.


================
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663
 
+  // Create our global prioritized cleanup function.
+  if (!PrioritizedCXXStermFinalizers.empty()) {
----------------
jasonliu wrote:
> Just noting that this trunk of code have very similar logic counter part in `EmitCXXGlobalInitFunc`. It seems there is no easy way to common them up given the current way of implementing it. It may require a non-trivial amount of refactoring for us to common up the similar logic between init and cleanup. 
Yes, I thought about this as well but it looks if we'd like to common it up, we may need to create some template function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99291/new/

https://reviews.llvm.org/D99291



More information about the cfe-commits mailing list