[PATCH] D97116: Reduce the number of attributes attached to each function

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496
   //    function.
-  CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth));
+  if (LargestVectorWidth)
+    CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth));
----------------
wxiao3 wrote:
> For x86 backend, "LargestVectorWidth" default value is not zero but UINT32_MAX.
> Please refer to: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/X86/X86TargetMachine.cpp#L271
> Suggest revert this patch since it changes the code generated for x86.
Reproducer please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97116/new/

https://reviews.llvm.org/D97116