[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

[Saurabh Jha via Phabricator via cfe-commits]

SaurabhJha added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1219
+  } else {
+    SrcElementTy = SrcTy;
+    DstElementTy = DstTy;
----------------
fhahn wrote:
> We should be able to assert here that both types are not matrix types, I think?
I did `!SrcType->isMatrixType() && !DstType->isMatrixType()` instead of `!SrcType->isMatrixType() || !DstType->isMatrixType()` which I hope was the correct thing to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037