[PATCH] D100085: [X86] Support -march=rocketlake

Freddy, Ye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 8 00:17:27 PDT 2021


FreddyYe added a comment.

In D100085#2675965 <https://reviews.llvm.org/D100085#2675965>, @MaskRay wrote:

> In D100085#2675919 <https://reviews.llvm.org/D100085#2675919>, @FreddyYe wrote:
>
>> Hi @MaskRay, I tried to refactor, but met some difficulties. Since these defines are dictionary ordered, a new #define may insert into a common CHECK. So it is difficult to let different RUN share common CHECKs.
>
> Check prefixes of the same kind do not need to be contiguous.
>
>   // A:
>   // B:
>   // A:

I see. And It works. And I'll update. And thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100085/new/

https://reviews.llvm.org/D100085



More information about the cfe-commits mailing list