[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 7 11:55:43 PDT 2021


lebedev.ri updated this revision to Diff 335893.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Unguard the UBSan check under `-fstrict*`.

In D100037#2674610 <https://reviews.llvm.org/D100037#2674610>, @rsmith wrote:

> I assume your intent here is to eventually add LLVM parameter attributes indicating the function argument is correctly-aligned, which is why you're checking on call boundaries?

Yep, D99791 <https://reviews.llvm.org/D99791>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100037/new/

https://reviews.llvm.org/D100037

Files:
  clang/docs/ReleaseNotes.rst
  clang/lib/CodeGen/CGExpr.cpp
  clang/lib/CodeGen/CodeGenFunction.cpp
  clang/lib/CodeGen/CodeGenFunction.h
  clang/test/CodeGen/catch-function-pointer-argument-alignment.cpp
  compiler-rt/lib/ubsan/ubsan_handlers.cpp
  compiler-rt/test/ubsan/TestCases/Pointer/function-pointer-argument.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100037.335893.patch
Type: text/x-patch
Size: 10692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210407/6fbb9eea/attachment-0001.bin>


More information about the cfe-commits mailing list