[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

Saurabh Jha via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 7 11:36:15 PDT 2021


SaurabhJha added a comment.

In D100051#2674674 <https://reviews.llvm.org/D100051#2674674>, @erichkeane wrote:

> Hrmph... Phab ate my other comment, which was that the name `EmitCastBetweenScalarTypes` feels clunky.  Does `EmitScalarCast` or `EmitScalarScalarCast` sound better and capture the meaning correctly?

Yeah, good idea. I'll rename it to `EmitScalarCast`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100051/new/

https://reviews.llvm.org/D100051



More information about the cfe-commits mailing list