[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 7 11:24:19 PDT 2021


MaskRay added a comment.

In D99996#2673276 <https://reviews.llvm.org/D99996#2673276>, @sylvestre.ledru wrote:

> To understand better, we will be fixing a bug from 2015, correct?

Yes.

In D99996#2674407 <https://reviews.llvm.org/D99996#2674407>, @arichardson wrote:

> I believe adding the default triple is causing the wrong linker to be selected for me when compiling with -m32, so I'd be happy for this code to be removed.

Yes...

In D99996#2674495 <https://reviews.llvm.org/D99996#2674495>, @srhines wrote:

> Adding Dan as an FYI. While this doesn't impact Android platform or regular NDK users, I suppose that someone could have some esoteric build rules that are relying on this, but they should probably be more explicit about what they're running in those cases anyways.

The 2015 behavior is that a `--target=aarch64-linux-gnu` cross compile may pick up `x86_64-unknown-linux-gnu-{as,ld,gcc}`. First most Linux programs should be named `x86_64-linux-gnu-*`.
Second `x86_64-unknown-linux-gnu-{as,ld,gcc}`, even if exists, is unlikely to handle aarch64-linux-gnu builds... So the case should be very rare.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99996/new/

https://reviews.llvm.org/D99996



More information about the cfe-commits mailing list