[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 7 03:40:45 PDT 2021
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang/lib/Frontend/CompilerInstance.cpp:109
+ // other side of CUDA/OpenMP/SYCL compilation.
+ if (!hasAuxTarget() &&
+ (getLangOpts().CUDA || getLangOpts().OpenMPIsDevice ||
----------------
can we just do `!getAuxTarget()` and not introduce `hasAuxTarget()` ? i don't think the new api in the interface provides much value.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100024/new/
https://reviews.llvm.org/D100024
More information about the cfe-commits
mailing list