[PATCH] D99235: [HIP] Change to code object v4

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 6 15:11:28 PDT 2021


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:115
   std::string OffloadKind = "hip";
+  if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4)
+    OffloadKind = OffloadKind + "v4";
----------------
Should it be an error if we pass `-mcode-object-version=99` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99235/new/

https://reviews.llvm.org/D99235



More information about the cfe-commits mailing list