[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 6 12:15:20 PDT 2021


mstorsjo added a comment.

Not very familiar with the feature, but from the linked discussion it looks sensible to me, so +1, I can give a formal stamp a bit later if nobody else does.



================
Comment at: clang/test/Frontend/rewrite-includes-macros.cpp:15
+}
\ No newline at end of file

----------------
I guess the missing newline at end of file isn't one of the aspects that needs to be tested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99973/new/

https://reviews.llvm.org/D99973



More information about the cfe-commits mailing list