[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

[Saurabh Jha via Phabricator via cfe-commits]

SaurabhJha added inline comments.


================
Comment at: clang/include/clang/AST/OperationKinds.def:185
+/// CK_MatrixCast - A cast between matrix types of the same dimensions.
+CAST_OPERATION(MatrixCast)
+
----------------
This line is causing me issues that I don't know how to solve. If we leave it in the current place on line 185. The new tests Sema and CodeGen tests are passing but Clang.SemaOpenCL::sampler_t.cl and Clang.SemaOpenCL::sampler_t_overload.cl (along with other sampler tests) are failing.

And if I move it to the bottom, right after `CAST_OPERATION(IntToOCLSampler)`, the sampler tests pass but the new matrix conversion tests are failing. Am I missing something here? My understanding was implementing new cast kind is just the matter of defining a `CAST_OPERATION` in this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037