[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 6 11:22:55 PDT 2021


aaron.ballman added a comment.

I think the behavior is correct, but I do think the original diagnostic was somewhat better -- an attribute list *can* appear there, if you're lucky. Of course, the old diagnostic isn't great either because adding a `;` after the attribute isn't going to improve the situation for the user. So I think I'm actually fine either way, but maybe @rsmith has a preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99936/new/

https://reviews.llvm.org/D99936



More information about the cfe-commits mailing list