[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c:35
+vint16mf4_t test_vwadd_vx_i16mf4(vint8mf8_t op1, int8_t op2, size_t vl) {
+  return vwadd_vx(op1, op2, vl);
+}
----------------
khchen wrote:
> khchen wrote:
> > craig.topper wrote:
> > > Why do scalars require _wx or _vx, but vector don't need a suffix?
> > https://github.com/riscv/rvv-intrinsic-doc/blob/master/rvv-intrinsic-rfc.md#widening-vector-scalar-arithmetic-instructions
> > There is different overloading naming rule for _wx and _vx, and I just keep the default naming rule for vector version because I felt the overloading rule did not care about the naming consistent. 
> > 
> > But in https://github.com/riscv/rvv-intrinsic-doc/pull/76 we start to make overloading name seems more consistent. So I think making this case consistent is ok to me.
> > 
> > I could send a PR to intrinsic-doc, what do you think?
> Should I update this patch for https://github.com/riscv/rvv-intrinsic-doc/pull/77 PR?
I think that makes sense. It's more consistent for someone writing intrinsic code if the suffix is always there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99526/new/

https://reviews.llvm.org/D99526