[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Tue Apr 6 09:58:48 PDT 2021

vsavchenko added a comment.

In D69726#2671611 <https://reviews.llvm.org/D69726#2671611>, @Charusso wrote:

> In D69726#2671526 <https://reviews.llvm.org/D69726#2671526>, @vsavchenko wrote:
>
>> @Charusso 
>> It looks like this patch introduced a some weird false positive on PostgreSQL F16161734: report-guc.c-ParseLongOption-13-1.html <https://reviews.llvm.org/F16161734>
>> I'll try to look at it myself and minimize it, but maybe you can get an idea from a full report.
>
> Could you supply us with all the divergence please? If there is only one case, may we can ignore it by appending it to @NoQ's `extremely-weird-bugs.txt` so people can focus on more important stuff.
>
> What I see in the bug report is that: `line 3290 - guc_malloc()` returns null and it is a true positive.

1. It's the only bug in divergence.
2. The analyzer doesn't explain why it thinks that `guc_malloc` returns null pointer.  I find it alarming that it might assume it for all the wrong reasons.
3. It is a false positive because `guc_malloc` is called with `elevel == FATAL`, which causes `ereport` to fail the whole execution.

I believe that this problem is important because it is definitely a regression.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69726/new/

https://reviews.llvm.org/D69726