[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Tue Apr 6 07:18:27 PDT 2021

Ericson2314 added a comment.

In D99860#2670359 <https://reviews.llvm.org/D99860#2670359>, @phosek wrote:

> I'm worried that overriding `CMAKE_INSTALL_PREFIX` is going to break the runtimes build where we build compiler-rt, libcxx, libcxxabi, libunwind in a single CMake build, and compiler-rt always comes first see https://github.com/llvm/llvm-project/blob/98742e42fc50f58d3f2d3f2cdbbf540288c134b9/runtimes/CMakeLists.txt#L57.

Gotcha, and `if (LLVM_TREE_AVAILABLE)` would be true in that case? That means compiler-rt-specific variables are here to stay, but I no longer think that's so bad. See the latest https://reviews.llvm.org/D99484 for how polly works now, I can do that here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99860/new/

https://reviews.llvm.org/D99860