[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:105
+
+llvm::StringRef getSystemGPUArch(const ToolChain &T) {
+  // detect the AMDGPU installed in system
----------------
This function is useful for AMDGPU toolchain and HIP toolchain. Can it be a member of AMDGPU toolchain?


================
Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:9
+
+include_directories(${LIBOMP_INCLUDE_DIR})
+
----------------
This tool does not use omp header file. Why is this needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99949/new/

https://reviews.llvm.org/D99949