[clang] b78e883 - [CMake] Fix Python 3 lookup when building LLVM with tests

Dominik Montada via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 6 04:09:14 PDT 2021


Author: Dominik Montada
Date: 2021-04-06T13:09:06+02:00
New Revision: b78e883fd8b3745250220776dd8bb635edd95539

URL: https://github.com/llvm/llvm-project/commit/b78e883fd8b3745250220776dd8bb635edd95539
DIFF: https://github.com/llvm/llvm-project/commit/b78e883fd8b3745250220776dd8bb635edd95539.diff

LOG: [CMake] Fix Python 3 lookup when building LLVM with tests

Remove the find_package(Python3 ...) call from Tooling/CMakeLists.txt as
it would override the python 3 version determined in llvm/CMakeLists.txt.
This call did not respect the LLVM_MINIMUM_PYTHON_VERSION.

This fixes the check-all target when building LLVM on a system where the
default python version is not the minimum required version for running tests.

Reviewed By: serge-sans-paille

Differential Revision: https://reviews.llvm.org/D99715

Added: 
    

Modified: 
    clang/lib/Tooling/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/lib/Tooling/CMakeLists.txt b/clang/lib/Tooling/CMakeLists.txt
index 0a6fb99152dc..ce7936a53671 100644
--- a/clang/lib/Tooling/CMakeLists.txt
+++ b/clang/lib/Tooling/CMakeLists.txt
@@ -13,8 +13,6 @@ add_subdirectory(Syntax)
 add_subdirectory(DependencyScanning)
 add_subdirectory(Transformer)
 
-find_package(Python3 COMPONENTS Interpreter)
-
 # Replace the last lib component of the current binary directory with include
 string(FIND ${CMAKE_CURRENT_BINARY_DIR} "/lib/" PATH_LIB_START REVERSE)
 if(PATH_LIB_START EQUAL -1)


        


More information about the cfe-commits mailing list