[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Mon Apr 5 12:26:04 PDT 2021

tentzen marked 13 inline comments as done.
tentzen added a comment.

hi,  I believe I'd addressed all issues or concerns, and it's rebased to up-to-date source in new _main branch now. Does this look good to everyone? If I don't hear any objection in a couple of days, I will go ahead make this patch in. Again This is just part-1 of Windows SEH feature.  Without new option specified, it's a zero-impact change.

================
Comment at: clang/include/clang/Driver/Options.td:886
   HelpText<"Enable C++ exceptions">, Flags<[CC1Option]>;
+def fasync_exceptions: Flag<["-"], "fasync-exceptions">, Group<f_Group>,
+  HelpText<"Enable EH Asynchronous exceptions">, Flags<[CC1Option]>;
----------------
jansvoboda11 wrote:
> Can you rebase and use the new option marshalling infrastructure instead?
> 
> https://clang.llvm.org/docs/InternalsManual.html#adding-new-command-line-option
SEH Async-excception option is implemented the same way as CXX-exception or ObjC-exception.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344