[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

Mon Apr 5 03:20:35 PDT 2021

jansvoboda11 added a comment.

In D97462#2666698 <https://reviews.llvm.org/D97462#2666698>, @dexonsmith wrote:

> In D97462#2666485 <https://reviews.llvm.org/D97462#2666485>, @jansvoboda11 wrote:
>
>> Thanks for reporting that. D99606 <https://reviews.llvm.org/D99606> fixes one aspect of `-plugin-arg`, but it seems the order of generation is non-deterministic (most likely related to the underlying storage, `std::unordered_map`). I can look into it early next week, but I think simple sort in the generation code should do the trick.
>
> Can/should it just be changed to a `std::map`?

Yes, that that works as well. Fixed in D99879 <https://reviews.llvm.org/D99879>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97462/new/

https://reviews.llvm.org/D97462