[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types
Saurabh Jha via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Apr 4 15:09:19 PDT 2021
SaurabhJha added a comment.
In D99037#2668295 <https://reviews.llvm.org/D99037#2668295>, @SaurabhJha wrote:
> One other problem is somehow this test is failing https://github.com/llvm/llvm-project/blob/main/clang/test/SemaOpenCL/sampler_t_overload.cl#L6 with this error.
>
> /tmp/clang/test/SemaOpenCL/sampler_t_overload.cl:6:30: error: initializer element is not a compile-time constant
> constant sampler_t glb_smp = 5;
> ^
> 1 error generated.
>
> Not sure what's going on but will continue to debug. Let me know if there's something simple that I am missing here.
I think I got it. If I remove the definition of `CAST_OPERATION(MatrixCast)` from `OperationKinds.def`, it works. So probably a matter of defining it the correct way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99037/new/
https://reviews.llvm.org/D99037
More information about the cfe-commits
mailing list