[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`
John Ericson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Apr 4 09:33:48 PDT 2021
Ericson2314 updated this revision to Diff 335149.
Ericson2314 added a comment.
Remove stray `COMPILER_RT_INSTALL_PATH`
I am uncertain about is the redefining of `CMAKE_INSTALL_PREIX` in
`compiler-rt/cmake/base-config-ix.cmake`. This occurs under
`LLVM_TREE_AVAILABLE`. If this is just for separate compiler-rt builds
(separate invocation of CMake, that is), this is fine. But if on the other hand
this is for combination builds in a single CMake run, then this sort of
redefinition is no good as it will effect more than compiler-rt.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99755/new/
https://reviews.llvm.org/D99755
Files:
clang/CMakeLists.txt
clang/runtime/CMakeLists.txt
clang/runtime/compiler-rt/clang_linux_test_input.c
compiler-rt/cmake/Modules/AddCompilerRT.cmake
compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
compiler-rt/cmake/Modules/CompilerRTUtils.cmake
compiler-rt/cmake/base-config-ix.cmake
compiler-rt/include/CMakeLists.txt
compiler-rt/lib/dfsan/CMakeLists.txt
llvm/runtimes/CMakeLists.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99755.335149.patch
Type: text/x-patch
Size: 14250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210404/9cb2ff89/attachment-0001.bin>
More information about the cfe-commits
mailing list