[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

[Florian Hahn via Phabricator via cfe-commits]

fhahn added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:7400
+  } else {
+    return Diag(R.getBegin(),
+                diag::err_invalid_conversion_between_matrix_and_scalar)
----------------
When we get here, `SrcTy` may not necessarily be a scalar I think (see my earlier note about adding more invalid cast tests for some additional cases that might reach this code)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037