[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

[Saurabh Jha via Phabricator via cfe-commits]

SaurabhJha added a comment.

Added some inline comments on where I have some doubts.



================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:547
+      case CK_MatrixCast: {
+        // TODO: Handle MatrixCast here.
+      }
----------------
I thought doing changes here is is outside the scope of casting so I just left a TODO here. Please let me know if we want to do something else here.


================
Comment at: clang/test/CodeGen/matrix-cast.c:39
+
+  f = (fx5x5)i;
+}
----------------
I tried adding a float -> int conversion too but it failed because of this assertion https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGExprScalar.cpp#L1339-L1344 Hopefully that's intended.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037