[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:2314
+      llvm::Align Alignment =
+          getNaturalTypeAlignment(ThisTy, /*BaseInfo=*/nullptr,
+                                  /*TBAAInfo=*/nullptr,
----------------
arichardson wrote:
> Shouldn't the alignment also be valid for non-zero address spaces?
> 
> 
> This reminds me that I need to upstream our local CHERI changes to take the branch for all address spaces with an all-zero null pointer representation.
> Shouldn't the alignment also be valid for non-zero address spaces?

Probably. It should also be fine when null pointer is valid.
If other reviewers agree i can do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99790/new/

https://reviews.llvm.org/D99790