[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths
Ben Shi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 1 20:43:03 PDT 2021
benshi001 marked an inline comment as done.
benshi001 added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356
+void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs,
+ ArgStringList &CC1Args) const {
----------------
Anastasia wrote:
> function name doesn't adhere to the coding style.
Not sure your concern ? Other platforms also use the same function name.
```
void RISCVToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs,
ArgStringList &CC1Args) const {
void Linux::AddClangSystemIncludeArgs(const ArgList &DriverArgs,
ArgStringList &CC1Args) const {
void WebAssembly::AddClangSystemIncludeArgs(const ArgList &DriverArgs,
ArgStringList &CC1Args) const {
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97669/new/
https://reviews.llvm.org/D97669
More information about the cfe-commits
mailing list