[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

[Florian Hahn via Phabricator via cfe-commits]

fhahn added a comment.

In D99037#2665082 <https://reviews.llvm.org/D99037#2665082>, @SaurabhJha wrote:

> Hi Florian and John,
>
> Thanks for the comments so far. I figure it would be easier for further discussion if I have something concrete. Here's what I have right now:
>
> - A new CK_MatrixCast.
> - Sema code for C-style cast along with its tests.
> - My guess on places CK_MatrixCast will go in CodeGen. I have added a TODO in CGExprScalar.cpp indicating where I think we should implement the code gen for this conversion. There's a failing CodeGen test too.
> - I am not sure yet if we need to anything with StaticAnalyzer/Core/ExprEngineC.cpp. I got a warning that CK_MatrixCast needs handling there.
>
> My next step is to make it work for C style cast. Once that works, I can use that learning to implement static_cast.

Depending on how much work implementing the other casts is, but you may want to start with getting everything work for a single type (e.g. C-style casts) and then submit that first (with codegen support). Once that is done, adding the additional checks for the other casts should be much less work. It's also easier to review if the patch is not too big & doing too much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037