[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 1 13:19:06 PDT 2021


fhahn added a comment.

In D99037#2665030 <https://reviews.llvm.org/D99037#2665030>, @SaurabhJha wrote:

> Hey, elementary question about arcanist. I followed the steps here https://llvm.org/docs/Contributing.html#how-to-submit-a-patch and did
>
>   arc diff --edit --verbatim
>
> on my current branch. Probably one mistake I did was to do a `git reset HEAD~1` and create a new commit. Now its trying to create a new revision. Is that okay to create a new revision and abandoning this one?

You can't add multiple commits to the same review on Phabricator. If you have multiple commits that you want to update this review with, you can squash them into the commit you used to create this patch and then upload the updated commit. If you have multiple commit but only want to upload the latest, you can use `arc diff HEAD^`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037



More information about the cfe-commits mailing list