[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

John Ericson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 1 11:22:09 PDT 2021


Ericson2314 created this revision.
Herald added a subscriber: mgorny.
Ericson2314 requested review of this revision.
Herald added projects: clang, Sanitizers.
Herald added subscribers: Sanitizers, cfe-commits.

This patch removes those in order to simplify things for D99484 <https://reviews.llvm.org/D99484>.

As @phosek said in https://reviews.llvm.org/D99484#2662806

> I'm not sure if we still need `COMPILER_RT_INSTALL_PATH`. That
> variable is only used by `clang/runtime/CMakeLists.txt` which
> predates `runtimes/CMakeLists.txt` and was AFAIK only ever used by
> Apple. I think  we should consider removing
> `COMPILER_RT_INSTALL_PATH`. We'll need to check if
> `clang/runtime/CMakeLists.txt` is still being used or not.

I think it's easiest to have that conversation in a dedicated patch, so
I went and opened this right away.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99755

Files:
  clang/runtime/CMakeLists.txt
  clang/runtime/compiler-rt/clang_linux_test_input.c
  compiler-rt/cmake/Modules/AddCompilerRT.cmake
  compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
  compiler-rt/cmake/Modules/CompilerRTUtils.cmake
  compiler-rt/cmake/base-config-ix.cmake
  compiler-rt/include/CMakeLists.txt
  compiler-rt/lib/dfsan/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99755.334775.patch
Type: text/x-patch
Size: 12066 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210401/f0a60daf/attachment.bin>


More information about the cfe-commits mailing list