[PATCH] D99556: Add support to -Wa,--version in clang

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 1 10:09:51 PDT 2021


MaskRay added a comment.

In D99556#2664426 <https://reviews.llvm.org/D99556#2664426>, @nickdesaulniers wrote:

> In D99556#2662990 <https://reviews.llvm.org/D99556#2662990>, @jcai19 wrote:
>
>> We can probably remove the -fno-integraetd-as case.
>
> Or split it out into a separate test file with `// REQUIRES: linux`.  Either actually is fine by me.

No, we should reduce reliance on the host system. Printing `....as` is fine (with `-B`), but invoking it to get the output is not something we should do in isolated tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99556/new/

https://reviews.llvm.org/D99556



More information about the cfe-commits mailing list