[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

Thu Apr 1 09:01:12 PDT 2021

amccarth added a comment.

In D99580#2660040 <https://reviews.llvm.org/D99580#2660040>, @kamleshbhalui wrote:

> In D99580#2659858 <https://reviews.llvm.org/D99580#2659858>, @amccarth wrote:
>
>> It looks like the code change is for everyone, but the new test is specific to mingw.
>
> For Linux like platform it does not create problem because input file  path is already in POSIX style, so having a test case will not test the change because even without the change it will pass.

The fix is on the code path for all platforms, so running the test on all platforms could help catch future regressions.  There could also be unusual cases, such as cross compiling for Linux on Windows, and thus you could have Windows-style paths even though the target is Posix.  Or someone might further refine the fix to make more cases work correctly for mingw but inadvertently cause problems for other platforms.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99580/new/

https://reviews.llvm.org/D99580