[PATCH] D99593: [Clang][RISCV] Implement vlseg builtins.

[Roger Ferrer Ibanez via Phabricator via cfe-commits]

rogfer01 added a comment.

This is just a suggestion, feel free to ignore: a sequence of `T`s was easy to parse for the prototype but may be want to consider something like `T3v` rather than `TTTv`. I think it would simplify the `TString` tblgen class and those `std::string(N, 'T')`.



================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:594
   auto PType = Transformer.back();
+  static unsigned NFCount = 0;
   switch (PType) {
----------------
Was this meant to be `static` here?


================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:714
+
+  if (PType == 'v' && NFCount > 0) {
+    IsTuple = true;
----------------
We say `Tv` is invalid, looks like we should check this here and `PrintFatalError`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99593/new/

https://reviews.llvm.org/D99593