[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 31 11:12:57 PDT 2021


aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:203
+    SmallVector<QualType, 4> Ret;
+    const auto &EmplaceIfDifferent = [&Ret](QualType QT) {
+      if (QT.isNull())
----------------



================
Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:207
+
+      LLVM_DEBUG(QT.dump());
+
----------------
whisperity wrote:
> Actually this is one of those debug prints that should be removed and remained in here by accident.
Agreed, this one should be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75041/new/

https://reviews.llvm.org/D75041



More information about the cfe-commits mailing list