[PATCH] D99623: [WebAssembly] Implement i64x2 comparisons

Wed Mar 31 10:37:43 PDT 2021

tlively added inline comments.

================
Comment at: llvm/test/CodeGen/WebAssembly/simd-select.ll:313
 ; CHECK-NEXT:    # fallthrough-return
                                     <2 x i64> %x, <2 x i64> %y) {
   %c = icmp slt <2 x i64> %a, %b
----------------
tlively wrote:
> dschuff wrote:
> > pre-existing, but is there a reason why the CHECKs here are in the middle of the IR function signature?
> Wow, I hadn't noticed that. Will investigate.
Aha, it's likely because the regex in update_llc_test_checks.py does not know how to recognize when the parameter list is continued on the next line. It only recognizes the first line of the function as the declaration line and places the checks immediately after it.

I'll fix this before I land the patch. Better to have a long parameter declaration line than a split up parameter declaration line!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99623/new/

https://reviews.llvm.org/D99623