[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:258
+  DefinedOrUnknownSVal Size =
+      getDynamicSize(State, MR->getBaseRegion(), C.getSValBuilder());
 
----------------
Wait a bit, I think it should consider the offset too. So, `getDynamicSizeWithOffset` should be used IMHO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99658/new/

https://reviews.llvm.org/D99658