[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

[Balázs Benics via Phabricator via cfe-commits]

steakhal added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:3089
+struct ImportBlock : ASTImporterOptionSpecificTestBase {};
+const internal::VariadicDynCastAllOfMatcher<Decl, BlockDecl> blockDecl;
+TEST_P(ImportBlock, ImportBlocksAreUnsupported) {
----------------
thakis wrote:
> Does this have to be a global? It can just be in the TEST_P, no?
> 
> As-is, this causes linker errors: http://45.33.8.238/linux/43089/step_4.txt
> 
> If it does have to be a global for some reason, please put it in an unnamed namespace.
Hmm I don't know. I was just copy-pasting from for example line 515.
```lang=c++
const internal::VariadicDynCastAllOfMatcher<Expr, VAArgExpr> vaArgExpr;
```
How is my case different from that?
I thought it's the way of doing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99576/new/

https://reviews.llvm.org/D99576