[PATCH] D99556: Add support to -Wa,--version in clang

Jian Cai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 30 18:03:52 PDT 2021


jcai19 added inline comments.


================
Comment at: clang/test/Driver/as-version.s:9
+// RUN:   | FileCheck --check-prefix=GAS %s
+// GAS: GNU assembler
----------------
nickdesaulniers wrote:
> What happens if we run this on windows (where I suspect that GAS isn't available)?  Perhaps a `CHECK-NOT: clang` would be better?
CHECK-NOT does sound safer in this case. I've updated the test. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99556/new/

https://reviews.llvm.org/D99556



More information about the cfe-commits mailing list