[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

[Saurabh Jha via Phabricator via cfe-commits]

SaurabhJha added a comment.

Hey @fhahn @rjmccall ,

Thank you so much for your reviews. Apart from the rest of your comments, here are the two principle things I am going to do next:

1. Replace the `reinterpret_cast`with `static_cast`. Do you think I should focus this revision to C-style casts and do `static_casts` in another patch?
2. Create a new `CK_MatrixCast` and implement its handling.

Is there any existing code I can look at that can help me implement the handler code for `CK_MatrixCast`? I could look at vectors because I was doing `CK_Bitcast` but I don't think I can rely on that now. If there's no such existing code at the moment, that's not an issue. I think I should be able figure it out after I spend some more time on it.

Cheers,
Saurabh


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99037/new/

https://reviews.llvm.org/D99037