[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of comment requests noted below.



================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1583
                       ModuleToDefinedGVSummaries[M->getModuleIdentifier()],
-                      ModuleMap, CGOpts.CmdArgs)) {
+                      nullptr, CGOpts.CmdArgs)) {
     handleAllErrors(std::move(E), [&](ErrorInfoBase &EIB) {
----------------
Document constant parameter


================
Comment at: llvm/include/llvm/LTO/LTOBackend.h:48
 
 /// Runs a ThinLTO backend.
 Error thinBackend(const Config &C, unsigned Task, AddStreamFn AddStream,
----------------
Can you add a note here about the behavior with regards to ModuleMap depending on whether it is null or not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99554/new/

https://reviews.llvm.org/D99554