[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Tue Mar 30 09:44:45 PDT 2021

Max_S marked 9 inline comments as done.
Max_S added a comment.

In the last update I fixed now everything and changed the tests.

The tests use now verify format when possible. A bug here, kept me from doing it in a few places. I submitted a bug report for this: https://bugs.llvm.org/show_bug.cgi?id=49772

I hope this is now fine and can be merged into the master.

================
Comment at: clang/include/clang/Format/Format.h:1912
+    /// Keep existing empty lines after access modifiers.
+    /// MaxEmptyLinesToKeep is applied instead.
+    ELAAMS_Leave,
----------------
curdeius wrote:
> Shouldn't we put the same comment in `ELBAMS_Leave`?
> That goes outside the scope of this patch if it ELBAMS doesn't behave this way.
I submitted a bug report about this, since the behavior is different.

https://bugs.llvm.org/show_bug.cgi?id=49757

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98237/new/

https://reviews.llvm.org/D98237