[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4302
+def cpp : Flag<["-"], "cpp">, Group<f_Group>,
+  HelpText<"Always add standard macro predefinitions">;
+def nocpp : Flag<["-"], "nocpp">, Group<f_Group>,
----------------
tskeith wrote:
> This option affects command line macro definitions too. So maybe something like:
> `Enable predefined and command line preprocessor macros`
I've actually missed this case altogether - thank you for pointing it out. Updated accordingly.


================
Comment at: flang/lib/Frontend/FrontendOptions.cpp:23
   // TODO: Add Cuda Fortan files (i.e. `*.cuf` and `*.CUF`).
   return suffix == "f77" || suffix == "f90" || suffix == "F90" ||
       suffix == "ff90" || suffix == "f95" || suffix == "F95" ||
----------------
kiranchandramohan wrote:
> Unrelated comment: f77 is probably not free form.
Thanks for noticing and pointing out! https://reviews.llvm.org/D99494


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99292/new/

https://reviews.llvm.org/D99292