[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17865
+    ID = Intrinsic::riscv_crc32_b;
+    IntrinsicTypes = {ResultType, Ops[0]->getType()};
+    break;
----------------
With the llvm_any_ty change, you'll only need ResultType here.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:20
+    class BitMan_GPR_Intrinsics
+        : Intrinsic<[llvm_any_ty], [llvm_any_ty],
+                    [IntrNoMem, IntrSpeculatable, IntrWillReturn]>;
----------------
The second llvm_any_ty here should be LLVMMatchType<0> since the types need to be the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99009/new/

https://reviews.llvm.org/D99009