[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

Nikita Kniazev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 28 11:31:12 PDT 2021


nick updated this revision to Diff 333728.
nick added a comment.

In D69218#2654614 <https://reviews.llvm.org/D69218#2654614>, @steveire wrote:

> @nick Sorry that getting these changes merged takes so long.
>
> @njames93 If you have an alternative way forward, please let us know what it is.
>
> Otherwise, this LGTM too and we should merge it soon unless there are objections which haven't been addressed.

I had a PR in Boost that took 4 years to merge, so it is nothing new to me :D

Rebased, even though there was no conflicts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69218/new/

https://reviews.llvm.org/D69218

Files:
  clang/docs/LibASTMatchersReference.html
  clang/include/clang/ASTMatchers/ASTMatchers.h
  clang/lib/ASTMatchers/ASTMatchersInternal.cpp
  clang/lib/ASTMatchers/Dynamic/Registry.cpp
  clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
  clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
  clang/unittests/ASTMatchers/Dynamic/RegistryTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69218.333728.patch
Type: text/x-patch
Size: 18911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210328/25ef0fc1/attachment-0001.bin>


More information about the cfe-commits mailing list