[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: clang/test/AST/ast-dump-array-json.cpp:6
+
+// CHECK: "mangledName": "_ZN1A4TestE",
+// CHECK: "mangledName": "_ZN1A4TestE",
----------------
oToToT wrote:
> yaxunl wrote:
> > I am not sure if this test tests the code you change since the mangled variable name does not encode type.
> I think this test my code. Or, at least, this test will trigger a runtime error in the latest clang without this patch when mangling `A::Test`.
> 
> Also, maybe I could try construct a test to mangle variable with element type if needed.
> 
> WDYT?
I would like to see a test that verifies the `A<type>_` mangling is produced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99407/new/

https://reviews.llvm.org/D99407