[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Fri Mar 26 10:12:06 PDT 2021

probinson added a comment.

In D99250#2651953 <https://reviews.llvm.org/D99250#2651953>, @probinson wrote:

> In D99250#2651204 <https://reviews.llvm.org/D99250#2651204>, @dblaikie wrote:
>
>> Does anyone else have a DWARFv3 consumer they care about? (@aprantl and @probinson)
>>
>> Does anyone have a DWARF consumer that changes significantly based on the language version (I guess lldb (@aprantl can you confirm?)? I doubt gdb does (yeah, it just treats all C++ versions the same <https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/dwarf2/read.c;h=ee6f3f7f7e14f722ec9bb6780563fa0bbbe268cc;hb=refs/heads/master#l21006>)? how about Sony?)
>
> I believe Sony is only using v4/v5 at this point.  Regarding dialect controlling debugger behavior, I think it's unlikely, as distinguishing C++ dialects is new in v5, its adoption is pretty recent (at least for us), and we'd want behavior to be consistent across v4/v5 as much as possible.  I'll verify that with our debugger guys.

I've confirmed that our intent is not to have dialect-specific behavior.

> If LLDB actually does _not_ have behavior change based on dialect, then we might as well control language codes based on DWARF version, and the patch should proceed.

I grepped the lldb tree and found nothing...  @aprantl can you confirm?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99250/new/

https://reviews.llvm.org/D99250