[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

Abhina Sree via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 26 06:52:00 PDT 2021


abhina.sreeskantharajan added a comment.

In D99363#2652899 <https://reviews.llvm.org/D99363#2652899>, @aganea wrote:

> Sorry, but after this patch, I still see the issue mentioned in https://reviews.llvm.org/D96363#2650460
> @abhina.sreeskantharajan are you able to confirm the issue on your end?

I don't have a Windows machine to test on, but I assumed since the problem was in rewrite then this patch should have fixed it. Would you be able to confirm if reverting the change in clang/lib/Driver/Driver.cpp fixes the problem for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99363/new/

https://reviews.llvm.org/D99363



More information about the cfe-commits mailing list