[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Thu Mar 25 17:26:06 PDT 2021

jsji added a comment.

> Our practice has been for a "tuning" option to, effectively, expand into other options to control various bits of behavior.  Basically, there should never be behavior that can be controlled _only_ via the tuning option.  This is a design decision that was debated at length when we introduced tuning.

Agree, this is a good practise, we will certainly follow.

> I believe Sony is only using v4/v5 at this point. Regarding dialect controlling debugger behavior, I think it's unlikely, as distinguishing C++ dialects is new in v5, its adoption is pretty recent (at least for us), and we'd want behavior to be consistent across v4/v5 as much as possible. I'll verify that with our debugger guys.

Thank you Paul!

> If LLDB actually does _not_ have behavior change based on dialect, then we might as well control language codes based on DWARF version, and the patch should proceed.

We will wait for LLDB's confirmation then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99250/new/

https://reviews.llvm.org/D99250