[PATCH] D97993: [Driver] Suppress GCC detection under -B

Thu Mar 25 13:51:24 PDT 2021

MaskRay added a comment.

In D97993#2644664 <https://reviews.llvm.org/D97993#2644664>, @thakis wrote:

> Also broke something in chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1191244 (since fixed by switching something from `-B` to `--gcc-toolchain`. This only landed 4 days ago and already broke a lot of things (see above) -- chances are it's going to break many more things once it makes it into a release. Is this really worth the churn? The benefits seem fairly small from what I understand.

@thakis The benefit is large. With the previous behavior, the selected toolchain could be overridden by the system /usr and --gcc-toolchain or --sysroot could be accidentally overridden by -B.
aeubanks has fixed it via  https://chromium-review.googlesource.com/c/chromium/src/+/2781154 That's great.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97993/new/

https://reviews.llvm.org/D97993