[clang] 33930a0 - [clang] Pass option directly to command. NFC

[Shoaib Meenai via cfe-commits]

Author: Shoaib Meenai
Date: 2021-03-25T11:36:06-07:00
New Revision: 33930a0787f6007ba7ebf36384115bebb412e08a

URL: https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a
DIFF: https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a.diff

LOG: [clang] Pass option directly to command. NFC

This code was written back when LLVM's minimum required CMake version
was 2.8.8, and I assume ExternalProject_Add_Step didn't take this option
at that point. It does now though, so we should just use the option.
Setting the _EP_* property is entirely equivalent (and is in fact how
these commands behave internally), but that also feels like an internal
implementation detail we shouldn't be relying on.

Reviewed By: beanz

Differential Revision: https://reviews.llvm.org/D99322

Added: 
    

Modified: 
    clang/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/CMakeLists.txt b/clang/CMakeLists.txt
index 6535f84edbb7..e4d5dd77c69a 100644
--- a/clang/CMakeLists.txt
+++ b/clang/CMakeLists.txt
@@ -864,9 +864,6 @@ if (CLANG_ENABLE_BOOTSTRAP)
     set(CLANG_BOOTSTRAP_TARGETS check-llvm check-clang check-all)
   endif()
   foreach(target ${CLANG_BOOTSTRAP_TARGETS})
-    # exclude from main target
-    set_target_properties(${NEXT_CLANG_STAGE} PROPERTIES _EP_${target}_EXCLUDE_FROM_MAIN On)
-
     # Install targets have side effects, so we always want to execute them.
     # "install" is reserved by CMake and can't be used as a step name for
     # ExternalProject_Add_Step, so we can match against "^install-" instead of
@@ -884,6 +881,7 @@ if (CLANG_ENABLE_BOOTSTRAP)
       COMMENT "Performing ${target} for '${NEXT_CLANG_STAGE}'"
       DEPENDEES configure
       ALWAYS ${step_always}
+      EXCLUDE_FROM_MAIN ON
       USES_TERMINAL 1
     )